Use a cached object for syncErrors and syncWarnings #4010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gustavohenke
approved these changes
Apr 27, 2018
There was a problem hiding this comment.
It LGTM, but I rather have @erikras views on it before merging
|
Yep. Fine because of the immutable way we edit those values. 👍 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
|
Released in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that #3201 introduced a regression where a prop that was cached to the same value when falling back (#3072) now creates a new object each render. This can cause a rendering performance penalty hit due to preventing shallow prop comparisons.
This PR fixes the regression by always using the
emptyproperty from the plain structure, rather than from the structure being passed as an argument tocreateReduxForm(which I believe was the intended fix in #3201).