Create FormName render props component

[jedwards1211]

Based upon my suggestion in #4037

[danielrob]

This looks great. Could you just fix those code-climate eslint issues, and we'll await signoff/merge from Erik.

[jedwards1211]

@danielrob okay, I fixed the unused variable errors. But the third one:

Function describeFormName has 43 lines of code (exceeds 25 allowed). Consider refactoring.

I really don't think this is a helpful rule, at least not in the test directory, and I decline to fix this issue in protest against it. I'd be willing to make a PR to turn off this rule in the test directory though.

[jedwards1211]

Sweet, thanks guys! At some point I'll get around to releasing my createStructuredFormSelector function in a package of its own.

[jedwards1211]

@erikras is the goal with the LOC rule to notify you guys when a human code review is needed, and if the length of the function is justified, eslint-disable it?
25 lines of code is a really low threshold, especially considering cases where we destructure several dozen props from an object, and put each prop on its own line for readability. Number of characters in the function after minification would be a better metric than number of lines, but really I'd rather see a more theoretical measure of code complexity if anything than just number of lines or characters in the function.

[jedwards1211]

Check out https://github.com/jcoreio/redux-form-reselect

[erikras]

Released in v7.4.0.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.