Better Config typing #4468
Better Config typing #4468
Conversation
asazernik
force-pushed
the
better-config-typing
branch
from
cb79dc5
to
2bf680d
Compare
Codecov Report
@@ Coverage Diff @@
## master #4468 +/- ##
======================================
Coverage 100% 100%
======================================
Files 74 74
Lines 1694 1694
======================================
Hits 1694 1694
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #4468 +/- ##
=======================================
Coverage 98.96% 98.96%
=======================================
Files 74 74
Lines 1743 1743
=======================================
Hits 1725 1725
Misses 18 18
Continue to review full report at Codecov.
|
|
@asazernik do you have plans to work in the fix? |
|
Agh! Missed the previous comment. Replied inline. |
… types (I recommend viewing this change with word-oriented diff.) Props was duplicating certain props specified in Config, mostly in order to express different nullity of those props. Respecified this by splitting up Config based on nullity rules. This changes some of the typing in Props, because Config types have been kept up to date better. While moving asyncValidate from Props to config, made it optional; we were already checking for non-null, now Flow will enforce that.
asazernik
force-pushed
the
better-config-typing
branch
from
2bf680d
to
54f31c7
Compare
|
Published in |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
I'm working on putting less extraneous cruft into ReduxFormContext to avoid unnecessary re-renders. (These were causing bugs in my project.) Since this is a bit of a scary refactor, wanted to make sure (internal-use-only) Flow types were up to snuff first.