Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix immutable support" #4474

Merged
merged 1 commit into from May 30, 2019
Merged

Conversation

erikras
Copy link
Member

@erikras erikras commented May 30, 2019

Reverts #4471. We can't import from 'immutable' in handleSubmit. We've got to abstract this out into something that gets passed in or lives in structure.

Fixes #4473.

@renatoagds
Copy link
Contributor

renatoagds commented May 30, 2019

@erikras Can you say why this is running local with yarn link and in publish it broken? How can we simulate the real publish package?

@erikras
Copy link
Member Author

erikras commented May 30, 2019

How can we simulate the real publish package?

Wow. Great question. Seems like the sort of thing someone might have tackled before.

@erikras
Copy link
Member Author

erikras commented May 30, 2019

Travis is unhappy, but I'm gonna merge this and fix any problems locally.

@erikras erikras merged commit c59a977 into master May 30, 2019
@erikras erikras deleted the revert-4471-fix-immutable-support branch May 30, 2019 13:13
@erikras
Copy link
Member Author

erikras commented May 30, 2019

The combination of #4470 and #4471 broke the build, but with both reverts merged, it's fine.

esetnik added a commit to esetnik/redux-form that referenced this pull request May 30, 2019
@renatoagds
Copy link
Contributor

Published in v8.2.3.

@lock
Copy link

lock bot commented Jun 29, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible error in the last release
2 participants