fix: re-bind actionCreators to changed props.form #4492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4492 +/- ##
======================================
Coverage 100% 100%
======================================
Files 74 74
Lines 1744 1743 -1
======================================
- Hits 1744 1743 -1
Continue to review full report at Codecov.
|
opichals
force-pushed
the
ensure-actionCreator-is-re-bound-to-props-form-on-props-change
branch
from
d1e1a41
to
48c2e53
Compare
opichals
force-pushed
the
ensure-actionCreator-is-re-bound-to-props-form-on-props-change
branch
from
48c2e53
to
bd145f7
Compare
|
Updated with a test for the change. |
renatoagds
approved these changes
Jun 25, 2019
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
|
Published in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
mapDispatchToPropswas only called once as it was returning a() => computedActionscached function. But in order to reflect aformproperty updates when one re-uses the decoratedreduxForm()(DetailComponent)instance the bindings must be re-bound to the changedformprop value.