Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix _reduxForm context rewrite #4496

Merged
merged 2 commits into from Jun 25, 2019
Merged

Fix _reduxForm context rewrite #4496

merged 2 commits into from Jun 25, 2019

Conversation

renatoagds
Copy link
Contributor

Closes #4299

Viktor_the_great and others added 2 commits June 25, 2019 16:20
@renatoagds
Issue #4299
652437b 
Hoc component does not rewrite context value (_reduxForm) with props
add test to check not rewritable context
@renatoagds
chore(): update package.lock
1cc47a9
@codecov
Copy link

codecov bot commented Jun 25, 2019 •
edited

Codecov Report

Merging #4496 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #4496   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          74      74           
  Lines        1743    1744    +1     
======================================
+ Hits         1743    1744    +1
Impacted Files Coverage Δ
src/ReduxFormContext.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6c82d8...1cc47a9. Read the comment docs.

@renatoagds renatoagds mentioned this pull request Jun 25, 2019
Closed
@renatoagds renatoagds merged commit d7d4e0b into master Jun 25, 2019
@renatoagds renatoagds deleted the fix-context-rewrite branch June 25, 2019 20:28
@lock
Copy link

lock bot commented Jul 25, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 25, 2019
@renatoagds
Copy link
Contributor Author

Published in v8.2.5.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error: formValues() must be used inside a React tree decorated with reduxForm()
1 participant
@renatoagds