fix: flow immutable js action creators #4632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamandrewluca
approved these changes
Mar 19, 2020
Codecov Report
@@ Coverage Diff @@
## master #4632 +/- ##
=======================================
Coverage 99.47% 99.47%
=======================================
Files 74 74
Lines 1729 1729
=======================================
Hits 1720 1720
Misses 9 9 Continue to review full report at Codecov.
|
|
Thanks! |
|
Published in |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems the immutable flow action signatures are wrong. They were already fixed in the native JS version (index.js.flow), but immutable.js.flow was different. This pull request fixes the discrepancy.