New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove UNSAFE_componentWillMount and fix initialValues not passed to validation #4741
Remove UNSAFE_componentWillMount and fix initialValues not passed to validation #4741
Conversation
…validation. Issues: redux-form#4628, redux-form#4642 Ported from shanshanzhu@d59ea8e Updated React development version to 17.0.2
…eateField.js Replaced UNSAFE_componentWillMount on componentDidMount in reduxForm.spec.js
…eateFieldArray.js
@erikras hi, as we discussed, please check this. |
Maybe outside the scope of this fix, but to be (perhaps a bit too) blunt, the problem here is #4020 It might have fixed a bug with the wrong values being passed in under one particular set of conditions - but completely broke the behaviour of initial setup, where previously the So, validation not getting |
@shanshanzhu please check this too, because it based in your changes |
@sanex3339 LGTM |
Is there any ETA of when will this be released? |
Checking in on an ETA for release. Thanks! |
@erikras @iamandrewluca is there a chance this PR or #4728 will be merged? |
@erikras May you review this PR to enable React 17 support to prevent it falling behind too far especially React 18 has been out for a few months? 🙏 |
@erikras UP 🙏 |
👍 |
@erikras May I ask when this will be released? I am eagerly awaiting this fix. |
Published in |
Remove UNSAFE_componentWillMount and fix initialValues not passed to validation.
Issues: #4628, #4642
Partially ported from shanshanzhu@d59ea8e
Updated React development version to 17.0.2