Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass correct function params #892

Closed
wants to merge 1 commit into from
Closed

Pass correct function params #892

wants to merge 1 commit into from

Conversation

jansons
Copy link

@jansons jansons commented May 1, 2016

No description provided.

@erikras
Copy link
Member

erikras commented May 1, 2016

Ha! Thanks. Already did that in my local version. Thanks for your help. Closing, tho.

@erikras erikras closed this May 1, 2016
@jansons
Copy link
Author

jansons commented May 5, 2016

Hi, Erik!
Just wanted to let you know that this problem still exists in alpha.7 release (and quick look shows that there could be similar problem in FieldArray as well).

@erikras
Copy link
Member

erikras commented May 5, 2016

What the?? How on earth is this building or running, then?

@erikras
Copy link
Member

erikras commented May 5, 2016

OH! Because it's correct in the constructor! Got it.

@erikras
Copy link
Member

erikras commented May 5, 2016

I was actually about to write a test to hit the other createConnectedField() call because the test coverage report told me that it was untested. Hooray for test coverage! (and observant helpful folks like you 😄 )

erikras added a commit that referenced this pull request May 5, 2016
@jansons
Copy link
Author

jansons commented May 5, 2016

👍

@erikras
Copy link
Member

erikras commented May 9, 2016

Fix published as v6.0.0-alpha.8.

erikras added a commit that referenced this pull request May 18, 2016
@lock
Copy link

lock bot commented Jun 2, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants