Potential hot destroy fix

[erikras]

Hey, @gaearon, is a reasonable for a library to examine module.hot? This fixes #623.

[erikras]

I'm gonna merge this, but I might roll it back if @gaearon tells me it's a terrible idea.

[gaearon]

This is a bit weird. Why is this necessary?

React Hot Loader 3 shouldn’t unmount your components.
My other hot reloading solutions (Babel plugin and React Hot Loader 1) are deprecated.

[erikras]

Happening with webpack-hot-middleware@2.6.0. Is that deprecated, too?

[gaearon]

I would say this should be reverted.
It’s a tangible behavior difference between PROD and DEV.

If there is an issue with RHL, please file it in the RHL repo so I don’t forget to take a look.
Thanks!

[gaearon]

webpack-hot-middleware@2.6.0 is irrelevant, this is just transport. Whether you use it or webpack-dev-server has no difference here.

[erikras]

I guess I'm not seeing any other "hot" stuff in the example that demonstrates this, which I copied from one of your simpler examples not so long ago. Do you see something in there that's deprecated?

[erikras]

Maybe it's this bit that needs modernizing?

[gaearon]

Oh, I see what you mean now. I didn’t realize you were using vanilla HMR API.

With vanilla HMR, it’s expected that components get unmounted on change.
(That’s exactly what React Hot Loader 3 solves.)

So if Redux Form destroys on unmount, everything behaves as expected.
You can add RHL 3 to prevent unmounting on hot reload, if you’d like.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.