add config to control logging of effect errors even when handled #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the delay. This looks good. Thanks! 2 things: Also, can you add some documentation for this option? Probably just something quick in the install page. https://redux-loop.js.org/docs/api-docs/install.html (the docs are in this repo). Thanks! |
…lures DONT_LOG_ERRORS_ON_HANDLED_FAILURES by default is set to false
jamesjtong
force-pushed
the
jt/fix-issue-with-error-swallowing-with-configs-save
branch
from
2518c0d
to
2b4c792
Compare
|
Sorry for the delay! Thanks for fixing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a config option to install.
Currently the only option is
DONT_LOG_ERRORS_ON_HANDLED_FAILURES(see #194, which fixed the issue where error messages were being swallowed in effects when the client added a failActionHandler on a Cmd) which is set to false by default. This means that by default, redux-loop will log errors in your effects even if you pass in a failActionCreator to a command (passing in a failActionCreator does not swallow errors like howcatchis used for Promises).