Fix TypeScript tests so they fail for errors 😭 #209
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the TypeScript tests aren't working. Here's a patch that should trigger a test failure:
Only after passing the error to
done()
(which totally isn't documented correctly), I get a test failure:There was an error about some usage of
Promise
which I fixed with some lib configuration. Unfortunately I couldn't find a way to usetsconfig.json
directly.