-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrap actions from unbatched lists in the tagger from Cmd.map #235
Conversation
@@ -82,7 +84,7 @@ function handleParallelList( | |||
} | |||
|
|||
return possiblePromise.then(result => { | |||
return Promise.all(result.map(a => dispatch(a))); | |||
return Promise.all(result.map(a => wrappedDispatch(a))); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the key is here. We use the wrapped dispatch rather than the vanilla one.
I could see something like this maybe being needed in the new timeout/delay Cmd types also, but we can deal with that after this is merged (or I will add it if that gets merged first)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I also realized this will be an issue for Cmd.setTimeout. And yes we can solve it separately.
@bdwain I had another idea after reading the discussion of the return type of dispatch #237 What if instead of returning The disadvantage is that this idea would require a bigger refactor. On the plus side it makes |
236b300
to
c31b4de
Compare
@laszlopandy can you make a separate issue to discuss that? It sounds interesting, though I'm not totally clear on what problem it's solving. But I think whatever it is would be separate from this change. |
@laszlopandy one other thing is that that change sounds like it could potentially be a breaking change, and if so, we'll want to wait to do a v6 until we have it merged, since this and a few of the other changes going out are breaking too. |
c31b4de
to
fe21e14
Compare
@laszlopandy this should address the list issue from #218