Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use jest instead of mocha/sinon/chai #432

Open
cilice opened this issue Feb 22, 2018 · 1 comment
Open

Use jest instead of mocha/sinon/chai #432

cilice opened this issue Feb 22, 2018 · 1 comment

Comments

@cilice
Copy link
Contributor

cilice commented Feb 22, 2018

Hey!

Another thing that I find worthy is to switch to jest instead of the mocha/sinon/chai trio.

Right now, old versions of sinon and mocha are used, with both being 2 major releases behind current. 😱

screen shot 2018-02-22 at 02 57 13

One big value which I find is that we would be able to generate source maps without much hassle, and having 1 dependency is somehow easier than having 3. There is also a generator that can convert the tests automatically to the jest syntax or with the 4 test files, I could convert them by hand.

Oh, and did I mention the test-runner of jest? it's pure love. <3

@jayphelps
Copy link
Member

jayphelps commented Feb 22, 2018

Right now, old versions of sinon and mocha are used, with both being 2 major releases behind current

These days I often take the "if it ain't broke don't fix it" stance to dependencies. They are indeed out of date, but I haven't noticed as far as lack of features or bugs so the effort hasn't been worth it for me.

Of course if someone else wants to do it, by all means! 😁

We do have greenkeeper setup, but I only use it because it will trigger a rebuild with those new updates and tell me if they would become breaking changes, so I can keep it in mind if/when I did every upgrade.


As far as switching to Jest, I like (and use) Jest on some projects too. If you want to switch and there are no negatives you can think of, have at it! 👍

I've run into some minor things I didn't like about it, but I don't think they impact this project and even if they did they weren't dealbreakers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants