fix(createEpicMiddleware): Don't share a scheduler queue with anyone else's RxJS code #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…else's RxJS code, fixes #624
jayphelps
commented
Mar 21, 2019
| { type: 'ACTION_4' } | ||
| ]); | ||
|
|
||
| done(); |
There was a problem hiding this comment.
This isn't really "async" in the sense of needing this done() but I prefer to have it regardless in case of later refactors later that do in fact introduce async that might cause the test to pass without actually making any assertions.
evertbouw
approved these changes
Mar 21, 2019
|
Landed in v1.1.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #624
Since we use the same queueScheduler that other people's app code might also use, we would get different behavior if the rootEpic is passed to
epicMiddlweare.run(rootEpic)inside an already running queueScheduler task. Before this PR we incorrectly relief on the fact that almost always this wouldn't happen, but it can. If it does, redux-observable won't subscribe to the rootEpic soon enough--it'll be deferred until the current queue task returns, potentially missing actions.RxJS doesn't currently publicly export QueueScheduler constructor nor QueueAction, so we reach in using arguably private APIs.
@benlesh this is doing naughty things, reaching into (currently) private APIs. If you have a moment to give this a quick once over, lmk if you have alternative suggestions. If no time, no worries.