deprecate thunkservables and rename things to Epic #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| return (action) => { | ||
| if (typeof action === 'function') { | ||
| if (typeof console !== 'undefined' && typeof console.warn !== 'undefined') { | ||
| console.warn('DEPRECATION: Using thunkservables with redux-observable is now deprecated in favor of the new "Epics" feature. See https://github.com/redux-observable/redux-observable/blob/docs/docs/SUMMARY.md'); |
There was a problem hiding this comment.
Once the new docs are up, we will change this URL to point to the new docs at redux-observable.js.org
jayphelps
force-pushed
the
thunk-deprecate
branch
from
09f06dc
to
5cbcce4
Compare
This was referenced Jul 12, 2016
|
@Blesh Once this is merged, don't publish a new release yet. We'll merge the new docs first, then publish. |
jayphelps
force-pushed
the
thunk-deprecate
branch
from
5cbcce4
to
ad1d621
Compare
…rvable()` to `createEpicMiddleware()`, `combineDelegators()` to `combineEpics()` BREAKING CHANGE: We are deprecating thunkservables in favor of the new process managers called "Epics". See https://github.com/redux-observable/redux-observable/blob/docs/docs/SUMMARY.md for more information on Epics. BREAKING CHANGE: Creating the middleware is now done with `createEpicMiddleware(rootEpic)` instead of `red uxObservable(rootEpic)` and `combineDelegators()` has been renamed `combineEpics()`
jayphelps
force-pushed
the
thunk-deprecate
branch
from
ad1d621
to
29edab5
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: We are deprecating thunkservables in favor of the new "epic"-style. Now, creating the middleware is done with
createEpicMiddleware(rootEpic)instead ofreduxObservable(rootEpic)andcombineDelegators()has been renamedcombineEpics(). See the brand new gitbook documentation (landing soon in #66) for more details on Epics.