Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AsyncStorage to community packager for RN60 #349

Closed
usrbowe opened this issue Aug 26, 2019 · 2 comments
Closed

Update AsyncStorage to community packager for RN60 #349

usrbowe opened this issue Aug 26, 2019 · 2 comments

Comments

@usrbowe
Copy link
Contributor

usrbowe commented Aug 26, 2019

Not sure if I'm missing something, but how come there is still AsyncStorage imported directly from react-native in @redux-offline/redux-offline@native.0 tag?

Referencing to:

import { AsyncStorage } from 'react-native'; // eslint-disable-line

Shouldn't that be imported from community package, since it was extracted in RN60?

So instead of

import { AsyncStorage } from 'react-native';

should be like

import AsyncStorage from '@react-native-community/async-storage';
@sorodrigo
Copy link
Member

That branch currently only contains the fix for NetInfo if you make a PR I'm happy to merge the AsyncStorage fix.

@usrbowe
Copy link
Contributor Author

usrbowe commented Sep 2, 2019

Solved in latest release in native branch: https://www.npmjs.com/package/@redux-offline/redux-offline/v/2.5.2-native.1

@usrbowe usrbowe closed this as completed Sep 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants