Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace RN AsyncStorage with community package #350

Merged
merged 1 commit into from Aug 30, 2019
Merged

replace RN AsyncStorage with community package #350

merged 1 commit into from Aug 30, 2019

Conversation

usrbowe
Copy link
Contributor

@usrbowe usrbowe commented Aug 27, 2019

Fixes #349

Replace deprecated 'react-native' AsyncStorage module with community package.

For RN60+

@calumpeak
Copy link
Member

@usrbowe thanks for this - Im not massively familiar with RN so thank you for bringing this to our attention. These kinds of issues are something we want to me more pluggable/easily fixable with V3.

@calumpeak calumpeak merged commit f2df3dd into redux-offline:native Aug 30, 2019
@calumpeak
Copy link
Member

@sorodrigo when you get a chance 👍

@sorodrigo
Copy link
Member

I removed the @react-native-community/async-storage because it's an optional dependency that should be installed externally, same as NetInfo and react-native.

@sorodrigo
Copy link
Member

Also I changed the tag so it's not constantly changing, now the Native tag is native. Before it was native.0 apologies.

@nickineering nickineering mentioned this pull request Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants