Fixed many2many empty relationships update case

[carlesnunez]

The next PR fix a bug related with the update of relationships that doen't have the data. For example:

If we have a model called books that have alot of authors and:

• We create books with an array of authors but we don't create the authors at the same time
• We update the books with the same authors id's but keeping without have the authors created

Then the update function tries to do .add with id's that are not linked without any record and throw an error.

I propose the fix that follow in that PR

[carlesnunez]

@tommikaikkonen any thought about that?

[tiii]

I did not try this, but just from the naming of the variables I would expect that you no longer can update a relation from no entities to some entities?

I submitted a fix for that about 2 months ago, which also includes some tests for the bug: #86

[carlesnunez]

What do u mean when you say "No entities to some entities?"

I am using this on a heavy app and it's working really well.

[constantx]

I think i'm running into this issue too.

[carlesnunez]

I have a forked package with this fixed for testing called redux-orm-kerad until that pr is merged or someone brings light. Maybe it will help u

[tiii]

@carlesnunez thanks for getting back to me on this!

I created a test case to better express what I mean:

it('updating related many-to-many entities from none to some works', () => {
    const { Book, Genre } = session;
    const book = Book.create({
        name: 'My new Book',
        genres: [],
    });
    expect(book.genres.toRefArray().map(row => row.id))
        .to.deep.equal([]);

    const addGenre = Genre.withId(2);

    book.update({ genres: [addGenre] });
    expect(book.genres.toRefArray().map(row => row.id))
        .to.deep.equal([2]);
});

With your changes this fails with:

1) Integration Immutable session updating related many-to-many entities from none to some works:

      AssertionError: expected [] to deeply equal [ 2 ]
      + expected - actual

      -[]
      +[
      +  2
      +]

The newly created book has no genres at first. If you try to add some later on the change will be discarded since currentIds.length > 0 will always return false.

I think that #86 fixed the error we are describing and this is now merged into master. Please let me now if I got you right on this!

Considering that you opened another PR (#124) based on this functionality, maybe this PR here could be closed?

[carlesnunez]

Hello! Close that issue nad i'll check the new redux-orm version. Is it as a new npm version too?

[tiii]

Unfortunately there is no new npm release yet. @tommikaikkonen any plans on releasing a new rc?

[NathanBWaters]

Hi @tiii
We'll be releasing a new npm rc tonight with #86 in it!

[NathanBWaters]

Released. 👍

[NE-SmallTown]

I notice that the the releases panel doesn't update,what happened?

[NathanBWaters]

@NE-SmallTown hmm great note. There's a step I must have missed. I'll fix that up. 👍
@tommikaikkonen probably should have taken you up on your step-by-step offer on how you do releases. :) I'll get that from you on Thursday