Use Symbol.for to create symbols in the global symbol registry
#290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change, when using redux-orm across JavaScript contexts (such as iframes and secondary windows), each context will have a unique reference for of the symbol for a key. This was leading to failed symbol checks. One specific use case this change supports is as follows - 1. Use redux-orm in a browser window to create ORM state. 2. Create a selector using an ORM instance as a parameter In a secondary window with its own copy of redux-orm. 3. Run that selector, passing in the state reference from the primary window. Without Symbol.for, the `isOrmState` check in memoize.js fails, resulting in the selector's result function receiving the ORM state instead of the session instance.
|
I think this makes a whole lot of sense. Thanks! |
|
Thanks @haveyaseen. Would you mind cutting a new release with this change? |
|
@ahutchings Released as v0.14.1 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, when using redux-orm across JavaScript contexts (such as iframes and secondary windows), each context will have a unique reference for of the symbol for a key. This was leading to failed symbol checks.
One specific use case this change supports is as follows -
Without Symbol.for, the
isOrmStatecheck in memoize.js fails, resulting in the selector's result function receiving the ORM state instead of the session instance.