Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle 'desc' order in QuerySet.orderBy #311

Conversation

tomasz-zablocki
Copy link
Collaborator

closes #309

  • Make sure you propose PR to correct branch: hotfix for master, feature for latest active branch feature/x.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

Fix to convert function bug, incorrectly handling false and 'desc' values.

@haveyaseen haveyaseen merged commit 913945d into redux-orm:master Oct 3, 2019
@codecov-io
Copy link

codecov-io commented Oct 3, 2019

Codecov Report

Merging #311 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #311      +/-   ##
==========================================
+ Coverage   99.81%   99.81%   +<.01%     
==========================================
  Files          28       28              
  Lines        1083     1086       +3     
  Branches      219      219              
==========================================
+ Hits         1081     1084       +3     
  Misses          2        2
Impacted Files Coverage Δ
src/QuerySet.js 100% <ø> (ø) ⬆️
src/db/Table.js 98.9% <100%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2469e04...4231c47. Read the comment docs.

@tomasz-zablocki
Copy link
Collaborator Author

thx @haveyaseen

@ghost
Copy link

ghost commented Apr 20, 2020

@tomasz-zablocki @haveyaseen Where exactly can you use orderBy? It's not working in my selectors. It says it's not a function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

orderBy in descending order doesn't work
3 participants