Make STATE_FLAG a string to fix serialization. #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves redux-orm#320 JS symbols aren't serializable, so we should use a string for the `STATE_FLAG` in the orm state.
kirbycool
commented
Oct 7, 2019
src/test/functional/serialization.js
Outdated
| orm = createTestORM(); | ||
| }); | ||
|
|
||
| it("can serialize and deserialized the state", () => { |
There was a problem hiding this comment.
This test fails before the change.
Let me know if there's a better place to put the test.
haveyaseen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #320
JS symbols aren't serializable, so we should use a string for the
STATE_FLAGin the orm state.