New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[refactor] join(...tasks) & cancel(...tasks) should return join/cancel descriptors #1515
Comments
I'm inclining to single array argument. The problem with variadic arguments I found is that It is clearer to use array argument: If you pass a single task object, then the result is a single result object; if you pass an array of tasks, then the result is an array too. Like in By the way, this issue had got some discussion in #1248. |
You have convinced me to array argument with simplicity of input arg type to output arg type mapping 👍 |
@shinima would you like to work on it? |
OK. I'll get it done in a few days. |
Done in #1527 |
At the moment they are internally wrapped in
all
but actually the effect type should get preserved so internal refactor is needed.At the same time we might consider changing those signatures to:
but I'm still on the fence with that, not sure which one is better - variadic arguments or a single array argument? any fresh thoughts on this one @restrry @shinima ?
The text was updated successfully, but these errors were encountered: