Setup eslint for react #1521
Merged
Setup eslint for react #1521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshustov
reviewed
Jul 5, 2018
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "extends": "eslint:recommended", | |||
| "extends": ["eslint:recommended", "plugin:react/recommended"], | |||
There was a problem hiding this comment.
should we add "plugin:react/recommended" only for examples folder?
There was a problem hiding this comment.
Agree. There are no react code in packages folder.
|
Sadly, ESLint does not support
@restrry How about just keeping |
|
ok |
|
Rebased this upon master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that eslint fails to run in examples folder. So I install
eslint-plugin-reactand eslint now will lint the examples folder too. I'll update the code in example folder gradually.