Better error printing in non-browser environments (node.js) #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yelouafi
added a commit
that referenced
this pull request
Mar 16, 2016
Better error printing in non-browser environments (node.js)
|
Thanks this would be very useful also in my unit tests |
yeah, I think it could be achieved by passing the call hierarchy as param to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using redux-saga in an Electron app and most of my sagas run node-side.
In node.js, error objects passed to
console.warnorconsole.errorjust print the error's prototype name and message, not the trace:I changed it to manually print the trace, if one is available:
It could be improved even more by tracking the whole saga chain so we know how we ended up there, but that's already a big step up :)