Added "jsnext:main" entry to package.json for ES2015 module import. #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yelouafi
added a commit
that referenced
this pull request
Mar 20, 2016
Added "jsnext:main" entry to package.json for ES2015 module import.
|
thanks. Haven't worked with rollup before, if this small addition would make it work then great :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do you think of rollup's proposal for supporting ES2015 module imports: https://github.com/rollup/rollup/wiki/jsnext:main ?
I've only been using rollup (instead of webpack) on a new project for a couple of days and haven't formed an opinion yet, but this small addition of a "jsnext:main" entry to package.json supports directly importing redux-saga's ES2015 source with rollup's "tree shaking" code elimination, and without needing an additional rollup commonjs plugin.