Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2385: fixed put/putResolve typings for thunk actions #2386

Merged
merged 3 commits into from
Aug 26, 2023

Conversation

qkudev
Copy link
Contributor

@qkudev qkudev commented Aug 16, 2023

Closes #2385

Fixes type checks for put and putResolve with thunk actions

Q A
Fixed Issues? #2385
Patch: Bug Fix? Yes
Major: Breaking Change? No
Minor: New Feature? No
Tests Added + Pass? No
Any Dependency Changes? No

@changeset-bot
Copy link

changeset-bot bot commented Aug 16, 2023

⚠️ No Changeset found

Latest commit: 2ef4843

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@neurosnap
Copy link
Member

Greetings!

Thanks so much for your contribution! Could you please add a couple of tests to https://github.com/redux-saga/redux-saga/blob/main/packages/core/types/effects.test.ts#L94

That will fail without your changes?

Thanks!

@qkudev
Copy link
Contributor Author

qkudev commented Aug 19, 2023

Thanks for feedback

Done!

Waiting for your review

Copy link
Member

@neurosnap neurosnap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much! We are almost there, just need more tests here:

function* testPut(): SagaIterator {

@qkudev qkudev requested a review from neurosnap August 25, 2023 08:27
Copy link
Member

@neurosnap neurosnap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last request: please add a changeset by running yarn changeset in the root and make it a patch:

---
'@redux-saga/core': patch
---

Fixes `put`/`putResolve` typings to support thunk actions

@qkudev qkudev requested a review from neurosnap August 26, 2023 05:22
@neurosnap neurosnap merged commit 9c59ac9 into redux-saga:main Aug 26, 2023
3 checks passed
@github-actions github-actions bot mentioned this pull request Aug 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TS2345 error while putting thunk actions
3 participants