-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#2385: fixed put/putResolve typings for thunk actions #2386
Conversation
|
Greetings! Thanks so much for your contribution! Could you please add a couple of tests to https://github.com/redux-saga/redux-saga/blob/main/packages/core/types/effects.test.ts#L94 That will fail without your changes? Thanks! |
Thanks for feedback Done! Waiting for your review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much! We are almost there, just need more tests here:
function* testPut(): SagaIterator { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last request: please add a changeset by running yarn changeset
in the root and make it a patch
:
---
'@redux-saga/core': patch
---
Fixes `put`/`putResolve` typings to support thunk actions
Closes #2385
Fixes type checks for
put
andputResolve
with thunk actions