Named export createSagaMiddleware added to @redux-saga/core

[krutoo]

• named export createSagaMiddleware added to @redux-saga/core

According to #2396

Q	A
Fixed Issues?
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?	Yes
Tests Added + Pass?	Yes
Any Dependency Changes?

[changeset-bot]

⚠️ No Changeset found

Latest commit: e34339e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[Andarist]

I'd like to review the upstream issue first - before landing this - because I think this should not be necessary and I want to know what's happening. I'll try to take a look at this some time next week - but feel free to ping me if I forget.

[krutoo]

@Andarist there is some new details about the problem

webpack/webpack#17743 (comment)

[Andarist]

The resolution I'd like to take here is to migrate our build setup to https://github.com/preconstruct/preconstruct/ . I have part of the work done on some old branch but never got to finishing it. I believe that would resolve the issue since it would output dist files in a way that they would be compatible with a wide range of tools

[krutoo]

The resolution I'd like to take here is to migrate our build setup to https://github.com/preconstruct/preconstruct/ . I have part of the work done on some old branch but never got to finishing it. I believe that would resolve the issue since it would output dist files in a way that they would be compatible with a wide range of tools

@Andarist thanks a lot, but can you also add named export for createSagaMiddleware?

[cristian-eriomenco]

Can we take babysteps and merge this PR first? Its causing quite a bit of headache on rollup, side of things:

import createSagaMiddleware, { SagaMiddleware } from 'redux-saga';
...
const sagaMiddleware = createSagaMiddleware();

for cjs gets translated into:

var createSagaMiddleware = require('redux-saga');
...
const sagaMiddleware = createSagaMiddleware();

which lacks the .default()

A named export would be very handy, expecially with the VSCode's auto-import plugins which don't work with default exports.

[krutoo]

@cristian-eriomenco I would also really like to add named exports, it is convenient and will help solve build problems in our case

[shaunvdberg]

Hey @krutoo @Andarist

Any update on the above?