New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify return logic in handleActions; remove typeof check #106

Merged

timche merged 1 commit into redux-utilities:master from yangmillstheory:master

Jul 10, 2016

Contributor

yangmillstheory commented Jul 9, 2016

http://stackoverflow.com/a/4725697/2419669

For undeclared variables, typeof foo will return the string literal "undefined", whereas the identity check foo === undefined would trigger the error "foo is not defined".

For local variables (which you know are declared somewhere), no such error would occur, hence the identity check.

defaultState is declared as a parameter, so the typeof check is unnecessary (like here).


          simplify return logic; remove typeof check

0191e24

http://stackoverflow.com/a/4725697/2419669

timche merged commit 1dc2449 into redux-utilities:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment