Enforce reducer type in handleAction #131
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timche
approved these changes
Sep 27, 2016
|
@timche Should we change the base branch to |
|
Yep, changed here as well. |
|
Note to self: use |
timche
requested changes
Nov 2, 2016
| ? [reducers, reducers] | ||
| : [reducers.next, reducers.throw].map(reducer => (isNil(reducer) ? identity : reducer)); | ||
| if (!isFunction(reducer) && !isPlainObject(reducer)) { | ||
| throw new TypeError('Expected reducer to be a function or object with next and throw reducers'); |
There was a problem hiding this comment.
Just change this to use invariant and we are good to go ;)
yangmillstheory
force-pushed
the
hygiene/check-reducers
branch
from
13ab742
to
999ff0a
Compare
This was referenced Nov 3, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop silently coercing bad reducer types; be clear on the API contract.
This is like #129, except for
handleActioninstead ofcreateAction, so it has breaking changes.Note that this doesn't make downstream errors happen earlier and more clearly (I checked this in tests in wrong reducer types), it just clarifies and enforces the API contract.