Utilize lodash-es in es builds. #206
Conversation
|
Thanks @jaridmargolin, I'll take a look this weekend. How many bytes are saved when running https://github.com/acdlite/redux-actions/blob/master/package.json#L12? |
| return { | ||
| visitor: { | ||
| ImportDeclaration(path) { | ||
| const source = path.node.source; |
There was a problem hiding this comment.
Does this work?
const { node: { source } } = path;Not a big deal, just curious. It's a bit less verbose.
There was a problem hiding this comment.
I'm not sure. Its a fairly small piece of functionality isolated from the majority of the code base. I personally wouldn't spend too much time on worrying about aesthetic changes.
But if you have a really strong opinion here, I can attempt to make the change.
There was a problem hiding this comment.
No strong opinion, just thinking out loud.
There was a problem hiding this comment.
👍 appreciate you taking a look at everything
| @@ -62,6 +62,7 @@ | |||
| "dependencies": { | |||
| "invariant": "^2.2.1", | |||
| "lodash": "^4.13.1", | |||
There was a problem hiding this comment.
Do we still need lodash then? I don't have familiarity with lodash-es and the change in .babelrc, maybe you could give some context?
There was a problem hiding this comment.
Yes. lodash will still be used in the source code. The only piece that changes is the es compiled files.These distribution files are rewritten to utilize lodash-es instead of lodash.
|
I don't believe there will be any effect on UMD builds. The purpose here is just to reduce the duplicated lodash module included while building es source. |
|
🙌 thanks! |
|
@jaridmargolin can you respond to #208 (comment)? |
This pattern exists in a few libraries that often coexist with redux actions:
https://github.com/reactjs/redux/blob/master/build/use-lodash-es.js
https://github.com/rt2zz/redux-persist/blob/master/tools/use-lodash-es.js
Without this patch, my bundle contains lodash-es and lodash modules. With the patch included, I was able to shave off a few gzipped KBs by sharing the already required/included lodash-es modules.