Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Github Actions #387

Merged
merged 12 commits into from Jan 28, 2023
Merged

Add Github Actions #387

merged 12 commits into from Jan 28, 2023

Conversation

alexander-heimbuch
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jan 22, 2023

Codecov Report

❗ No coverage uploaded for pull request base (master@f9d655c). Click here to learn what that means.
Patch coverage: 93.06% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #387   +/-   ##
=========================================
  Coverage          ?   96.58%           
=========================================
  Files             ?       30           
  Lines             ?      468           
  Branches          ?      113           
=========================================
  Hits              ?      452           
  Misses            ?       15           
  Partials          ?        1           
Impacted Files Coverage Δ
src/utils/ownKeys.js 64.00% <ø> (ø)
src/utils/invariant.js 73.07% <73.07%> (ø)
src/combineActions.js 100.00% <100.00%> (ø)
src/createAction.js 100.00% <100.00%> (ø)
src/createActions.js 100.00% <100.00%> (ø)
src/handleAction.js 100.00% <100.00%> (ø)
src/handleActions.js 100.00% <100.00%> (ø)
src/utils/camelCase.js 100.00% <100.00%> (ø)
src/utils/flattenReducerMap.js 100.00% <100.00%> (ø)
src/utils/flattenWhenNode.js 100.00% <100.00%> (ø)
... and 15 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@timche timche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left out the review for publish.yml, because it will depend on how review.yml will be changed and it should follow it.

.github/workflows/review.yml Outdated Show resolved Hide resolved
.github/workflows/review.yml Outdated Show resolved Hide resolved
.github/workflows/review.yml Outdated Show resolved Hide resolved
.github/workflows/review.yml Outdated Show resolved Hide resolved
.github/workflows/review.yml Outdated Show resolved Hide resolved
.github/workflows/review.yml Outdated Show resolved Hide resolved
.github/workflows/review.yml Outdated Show resolved Hide resolved
.github/workflows/review.yml Outdated Show resolved Hide resolved
.github/workflows/review.yml Outdated Show resolved Hide resolved
.github/workflows/review.yml Outdated Show resolved Hide resolved
Copy link
Member

@timche timche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes! Looks good. Few comments on the publish workflow. Otherwise great progress and work! 👍

.github/workflows/main.yml Outdated Show resolved Hide resolved
.github/workflows/publish.yml Show resolved Hide resolved
.github/workflows/publish.yml Outdated Show resolved Hide resolved
.github/workflows/main.yml Outdated Show resolved Hide resolved
.github/workflows/publish.yml Show resolved Hide resolved
Copy link
Member

@timche timche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think it's looking good now! Just small remark on whether to run lint in release or not, but will let you decide.

@alexander-heimbuch alexander-heimbuch merged commit d8b7855 into master Jan 28, 2023
@alexander-heimbuch alexander-heimbuch deleted the ci/github-actions branch January 28, 2023 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants