Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spacing field type broken #24

Closed
teamcrisis opened this issue Sep 13, 2013 · 5 comments
Closed

Spacing field type broken #24

teamcrisis opened this issue Sep 13, 2013 · 5 comments

Comments

@teamcrisis
Copy link

@dovy it appears this field broke over the last few days. The Select for units is showing "1" instead of px,%, em. I also don't see the units in the output.

units

@dovy
Copy link
Member

dovy commented Sep 13, 2013

Fixed in d39a60c.

Had it default to true instead of px. My bad.

@dovy dovy closed this as completed Sep 13, 2013
@teamcrisis
Copy link
Author

Now only px shows in the select. Even if I set 'units'=>'em' px still shows

@teamcrisis
Copy link
Author

By the way, what do you think of changing the output? Instead of 5 it would return 5px or whatever the unit was.

@dovy
Copy link
Member

dovy commented Sep 13, 2013

Fixed again. Sorry about that. Had to think through my code.

68ca11e

The only way to add px is to force the users to enter it or something like that. It would be quite a lot of javascript pain to make it happen easier. Just append the units to each field. A units value will always be returned.

I also added in some fixes so you can only use the three possible values for margin/padding: px, em, %.

Thanks.

@teamcrisis
Copy link
Author

Works well. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants