Compiler fails on image_select field

[teamcrisis]

The compiler fails to run using image_select fields.

Example:

array(
    'id'=>'layout',
    'type' => 'image_select',
    'title' => __('Main Layout', 'redux-framework'), 
    'subtitle' => __('Select main content and sidebar alignment. Choose between 1, 2 or 3 column layout.', 'redux-framework'),
    'options' => array(
            '1' => array('alt' => '1 Column', 'img' => REDUX_URL.'assets/img/1col.png'),
            '2' => array('alt' => '2 Column Left', 'img' => REDUX_URL.'assets/img/2cl.png'),
            '3' => array('alt' => '2 Column Right', 'img' => REDUX_URL.'assets/img/2cr.png'),
            '4' => array('alt' => '3 Column Middle', 'img' => REDUX_URL.'assets/img/3cm.png'),
            '5' => array('alt' => '3 Column Left', 'img' => REDUX_URL.'assets/img/3cl.png'),
            '6' => array('alt' => '3 Column Right', 'img' => REDUX_URL.'assets/img/3cr.png')
        ),
    'default' => '2',
    'compiler'  => 'true',
    ),

[dovy]

Resolved in e49c0c9.

Thanks for all the great testing. You're fantastic.

[dovy]

If you want to go through each field type and verify compiler works that would be a HUGE help. Let me know if you're willing. (Obviously info wouldn't trigger it, ;) )

[teamcrisis]

Confirmed working. Thanks for getting this fixed. Yeah, I'll test each field for you. Give me a day or two...

[teamcrisis]

@dovy I'll need to do more testing tomorrow, It's getting late here, but I see two issues:

1. It seems the media field type doesn't trigger the compiler
2. In the demo options file, under the "Home Settings" tab, I see ids with media and media-min. Based on the descriptions I would have assumed these fields are different, but in the UI they look the same (both are using type => media). Is there a field type missing?

[teamcrisis]

@dovy

In addition to what I found with the two media issues (post above), here are some additional issues I found.

1. Sorter - not triggering compiler and options don't save when changed
2. Preset - only tested array but it doesn't trigger compiler and options set in array don't change the values of the other fields
3. Bug in sample-config.php - search for: "6"=>array - id is not in correct spot causing field to fail
4. Bug in sample-config.php - search for: Tags Select Option - id is missing causing field to fail

[dovy]

Media field has been fixed. dcfefc7

[teamcrisis]

Confirmed. Media field now triggers compiler. Will there be two different media fields at some point?

[dovy]

Why would we need two media fields? What are you looking for?

[teamcrisis]

What I'm referring to is on the Home Settings tab. I see "Media" and "Media Minimalistic". Based on the description of the minimalistic I assumed it was supposed to look and function slightly differently. Am I mistaken? I know smof had a similar concept.

[dovy]

@teamcrisis To keep things clean if you find another error please create a new issue. Close this one out when you've confirmed all the fixes.

Media - Fixed it up and added 2 examples. With URL and without preview.

Fixed the sorter.

Fixed presets.

Fixed the other sample-options.php errors.

Please confirm each here.

44b769e

[teamcrisis]

@dovy media seems to be fixed but I'm still seeing issues with the preset and sorter.

Sorter - compiles but options do not save. Drag an option to disabled and save. You should see it doesn't stay in the disabled column.

Presents - this is not compiling and it's not updating the fields in the array

[dovy]

If the presets are not saving perhaps how you define the preset is different than the way I setup. Can you give me your preset code?

Oy, the sorter. I'll get on it.

[teamcrisis]

I'm testing with the sample config. I haven't changed anything. It's working for you?

[dovy]

Indeed. Works without a problem with the newest code. I made some fixes...

[teamcrisis]

Hmm, strange. I just downloaded the files again and completely replaced them. Still having the issue.

[dovy]

Using the base options or custom?

[teamcrisis]

Base options - exactly what is in the repo

[dovy]

Join.me session?

[dovy]

@teamcrisis

Sorter fixed in 0f9652f. Closing this. If you're still having issues with presets let's have a join.me session.

Please make a new ticket for any additional issue. One ticket per issue. Thanks!

[dovy]

@teamcrisis You may want to see this: https://github.com/ReduxFramework/redux-converter