Try marking errors in catch blocks

reduxjs · Jul 9, 2021 · 0d5ded6 · 0d5ded6
1 parent 5b68e0e
commit 0d5ded6
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/src/components/connectAdvanced.tsx b/src/components/connectAdvanced.tsx
@@ -113,9 +113,9 @@ function subscribeUpdates(
         latestStoreState,
         lastWrapperProps.current
       )
-    } catch (e) {
+    } catch (e: unknown) {
       error = e
-      lastThrownError = e
+      lastThrownError = e as Error | null
     }
 
     if (!error) {

diff --git a/src/hooks/useSelector.ts b/src/hooks/useSelector.ts
@@ -50,9 +50,11 @@ function useSelectorWithStoreAndSubscription<TStoreState, TSelectedState>(
     } else {
       selectedState = latestSelectedState.current
     }
-  } catch (err) {
+  } catch (err: unknown) {
     if (latestSubscriptionCallbackError.current) {
-      err.message += `\nThe error may be correlated with this previous error:\n${latestSubscriptionCallbackError.current.stack}\n\n`
+      ;(
+        err as Error
+      ).message += `\nThe error may be correlated with this previous error:\n${latestSubscriptionCallbackError.current.stack}\n\n`
     }
 
     throw err
@@ -77,12 +79,12 @@ function useSelectorWithStoreAndSubscription<TStoreState, TSelectedState>(
 
         latestSelectedState.current = newSelectedState
         latestStoreState.current = newStoreState
-      } catch (err) {
+      } catch (err: unknown) {
         // we ignore all errors here, since when the component
         // is re-rendered, the selectors are called again, and
         // will throw again, if neither props nor store state
         // changed
-        latestSubscriptionCallbackError.current = err
+        latestSubscriptionCallbackError.current = err as Error
       }
 
       forceRender()