Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package.json, react-dom added in peerDependencies section. #1282

Closed
wants to merge 1 commit into from

Conversation

sultan99
Copy link

Added missing react-dom package to peerDependencies.

It cause problem for some plugins like dynamic-cdn-webpack-plugin.

Added missing react-dom package to peerDependencies.
@netlify
Copy link

netlify bot commented May 10, 2019

Deploy preview for react-redux-docs ready!

Built with commit 4792736

https://deploy-preview-1282--react-redux-docs.netlify.com

@timdorr
Copy link
Member

timdorr commented May 10, 2019

We support React Native as well, which doesn't use react-dom as a renderer. So, we can't make this a peer or regular dependency.

@timdorr timdorr closed this May 10, 2019
@sultan99
Copy link
Author

If you make it peer dependancy will it break react-native?

@sultan99
Copy link
Author

sultan99 commented May 10, 2019

@timdorr what about optional dependancy?

@timdorr
Copy link
Member

timdorr commented May 10, 2019

If you make it peer dependency will it break react-native?

No, it will just warn upon install for every RN user.

An optional dep doesn't apply, as that is for non-production use cases.

@sultan99
Copy link
Author

sultan99 commented May 10, 2019

@timdorr I think optional dependency is right choice:

and there is no deal with production or non-production use cases.

By refusing it you are depriving users of use cdn and other use cases.

@timdorr
Copy link
Member

timdorr commented May 10, 2019

No, we're not. This library works just fine with a CDN. We publish a UMD bundle with every release and link to it from the package.json for Unpkg.

It just doesn't work for that particular Webpack plugin. You can still add a script tag manually to use it from a CDN.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants