Convert connect components and logic to TS (with caveats) #1758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4d22f6a:
|
|
Size Change: -373 B (1%) Total Size: 19 kB
|
|
✔️ Deploy Preview for react-redux-docs ready! 🔨 Explore the source changes: 4d22f6a 🔍 Inspect the deploy log: https://app.netlify.com/sites/react-redux-docs/deploys/60e5eb8eb7d61f00087fe3e6 😎 Browse the preview: https://deploy-preview-1758--react-redux-docs.netlify.app |
lindskogen
reviewed
Jul 7, 2021
src/components/connectAdvanced.tsx
Outdated
| const [, updateCount] = state | ||
| return [action.payload, updateCount + 1] | ||
| } | ||
|
|
||
| type UseLayoutEffect = typeof useLayoutEffect | ||
| type EffectFunc = (...args: any[]) => void | ReturnType<React.EffectCallback> | ||
| type EffectDeps = Parameters<UseLayoutEffect>[1] |
There was a problem hiding this comment.
There is a DependencyList type exported from react if you'd like to use that instead!
|
Well, let's get this in, and we can review the types later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
connectAdvanced,connect, andselectorFactoryto TSThese types are absolutely not final! For one thing, I guarantee this isn't actually inferring the right props and carrying them through. That's going to take a lot more work (and probably from someone other than me).
Also, I had to slap a bunch of
unknownand// @ts-ignoreeverywhere. Some of those can maybe stay, because they're internal implementation details that aren't worth fussing over. Others probably ought to be fixed.But, I've at least managed to hack together enough types to get the files compiling without errors and sorta-mostly look correct-ish.
Ref: #1737