Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): added custom equalityFn example #1966

Merged
merged 1 commit into from
Oct 28, 2022

Conversation

ethen001
Copy link

issue: #1504
Adding documentation/example for custom equality function for useSelector()

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 28, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 54d8096:

Sandbox Source
Vanilla Configuration
Vanilla Typescript Configuration

@netlify
Copy link

netlify bot commented Oct 28, 2022

Deploy Preview for react-redux-docs ready!

Name Link
🔨 Latest commit 54d8096
🔍 Latest deploy log https://app.netlify.com/sites/react-redux-docs/deploys/635c0b41f44d4e0009ccfcde
😎 Deploy Preview https://deploy-preview-1966--react-redux-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@markerikson
Copy link
Contributor

Thanks! Can you tweak the naming a bit? The arguments aren't really "state", since they're the extracted values. Maybe something like oldValue or oldResult?

@ethen001 ethen001 force-pushed the chores/custom-equality-fn-docs branch from 05cf6fe to 54d8096 Compare October 28, 2022 17:02
@markerikson markerikson merged commit 8cf538c into reduxjs:master Oct 28, 2022
@markerikson
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants