Update TypeScript to 5.4 #2139
Merged
Update TypeScript to 5.4 #2139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
timdorr
reviewed
Mar 6, 2024
| @@ -51,7 +51,7 @@ jobs: | |||
| fail-fast: false | |||
| matrix: | |||
| node: ['18.x'] | |||
| ts: ['4.7', '4.8', '4.9', '5.0', '5.1', '5.2', '5.3'] | |||
| ts: ['4.7', '4.8', '4.9', '5.0', '5.1', '5.2', '5.3', '5.4'] | |||
There was a problem hiding this comment.
Do we want to drop some older versions at this point? 4.7 was released May 2022, 4.8 in August 2022, and 4.9 in November 2022.
I say we drop 4.7 and 4.8, since users that treat TS versions like semver may still be stuck on 4.9.
There was a problem hiding this comment.
generally i think we shouldn't drop testing against TS versions until we release a major version, to avoid accidental breaking changes
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR: