Add a way to create a Provider using a specific store key #695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm. Just from a maintenance standpoint, does Other than that, this seems reasonable at first glance in terms of concept and implementation. |
|
Sure. I changed it. Let me know if you'd like something else. |
timdorr
reviewed
May 10, 2017
src/components/Provider.js
Outdated
| Provider.propTypes = { | ||
| store: storeShape.isRequired, | ||
| children: PropTypes.element.isRequired, | ||
| }; |
|
I assume if we squash this, it wouldn't reflect the back-and-forth between files, right? |
|
It would reflect this: https://github.com/reactjs/react-redux/pull/695/files |
|
No need, we can squash on GitHub now. I do it every time, since it provides a nice link back to this PR. |
timdorr
approved these changes
May 11, 2017
|
👍 Hit it! |
josepot
pushed a commit
to josepot/react-redux-lean
that referenced
this pull request
Sep 21, 2018
* Add a way to create a Provider using a specific store key * Move createProvider inside Provider.js * Remove semicolons
webguru7
pushed a commit
to webguru7/react-redux
that referenced
this pull request
Dec 8, 2022
* Add a way to create a Provider using a specific store key * Move createProvider inside Provider.js * Remove semicolons
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related and fix #693. It offers an easy way to create a custom provider using a specific store key.
connectalready supported that feature, but theProviderwas missing it.