Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow resizing/collapsing #109

Closed
pdeva opened this issue Sep 14, 2015 · 10 comments
Closed

allow resizing/collapsing #109

pdeva opened this issue Sep 14, 2015 · 10 comments

Comments

@pdeva
Copy link

pdeva commented Sep 14, 2015

extremely tough to use cause sometimes its over the content/button that i need to use.
should allow resizing/collapsing.

@pdeva
Copy link
Author

pdeva commented Sep 14, 2015

For example, this screenshot explains this issue:
http://screencast.com/t/NTIDCeD1IV

@AsaAyers
Copy link

You can hide it, but I'm not aware of a way to resize it:

  • Toggle visibility with Ctrl+H
  • To hide the devtools on load, set visibleOnLoad to false, e.g.: <DevTools store={store} monitor={LogMonitor} visibleOnLoad={false} />

@pdeva
Copy link
Author

pdeva commented Sep 14, 2015

the shortcut is not documented anywhere.

also Ctrl+H is shortcut for 'History' in chrome. many times i trigger that when focus is not entirely inside window. a different shortcut would be much better.

@gaearon
Copy link
Contributor

gaearon commented Sep 14, 2015

the shortcut is not documented anywhere.

Why don't you make a PR then?

@gaearon
Copy link
Contributor

gaearon commented Sep 14, 2015

extremely tough to use cause sometimes its over the content/button that i need to use.
should allow resizing/collapsing.

You might be interested in giving feedback to #107.

@gaearon
Copy link
Contributor

gaearon commented Sep 14, 2015

also Ctrl+H is shortcut for 'History' in chrome. many times i trigger that when focus is not entirely inside window. a different shortcut would be much better.

File an issue, suggest another shortcut, make a PR. This is open source. If you can make it better, make it better.

@billyjanitsch
Copy link

the shortcut is not documented anywhere.

Actually, it's already documented in the Readme, which is what @AsaAyers was quoting.

The code responsible for defining Ctrl+H is here, if that helps.

Incidentally, even if you're not comfortable submitting a PR and don't have a specific improvement in mind, a little more politeness (e.g. "Is this shortcut documented? I don't see it") will make someone a lot more inclined to fix it for you. :) If you're going to make terse complaints, at least make sure to be correct.

@nicolabortignon
Copy link

I'm happy to implement this PR if everyone are ok with it:

  • adding a close/open toggle.
  • adding resize capabilities
  • leave CTRL+H as it is (doesn't conflict if the target is the page)

Thoughts ?

@gaearon
Copy link
Contributor

gaearon commented Sep 24, 2015

#107 addresses this partly.
It's on hold until LogMonitor is extracted into a separate project.

@gaearon
Copy link
Contributor

gaearon commented Sep 27, 2015

Let's track this in #132 which will include an official docking solution.

@gaearon gaearon closed this as completed Sep 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants