Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better space usage in DebugPanel view #153

Closed
kromit opened this issue Oct 13, 2015 · 9 comments
Closed

Better space usage in DebugPanel view #153

kromit opened this issue Oct 13, 2015 · 9 comments

Comments

@kromit
Copy link

kromit commented Oct 13, 2015

I use a full HD display and under some circumstances I can only see 4-5 last actions happened because of heavy vertical padding/margin usage in the styles. (2-3 visible actions with Chrome dev tools opened)

How about an option to remove all the vertical padding/margin styles at all to maximize the space usage? I mean I like the aesthetics but usability and productivity is more important here.

@gaearon
Copy link
Contributor

gaearon commented Oct 16, 2015

Can you make a screenshot so we can get a better idea of your setup?

@kromit
Copy link
Author

kromit commented Oct 16, 2015

Current state
current state

Desired state
desirable

I mean if it is for debugging so it also could look like debugging :) Also please notice Chrome dev tools font sizes.

@danielkcz
Copy link
Contributor

Well I think that spacing shouldn't be changed as it could introduce accidental clicks on something you didn't wanted. Much better solution could be automatic collapse basically to see just state and action in there by default. Or maybe make that configurable...

@kromit
Copy link
Author

kromit commented Oct 16, 2015

Since the panel is designed specially for debugging, there is a really small chance the panel is seen by someone who does not know what he is doing. The probability of accidental click will be much lower in comparison to the currently almost persistent need to scroll up and down. However I also think it should be configurable.

On the configurability: I am not a friend of inline React styles since I do work with less ans sass, so for me the best solution would be the optional disabling of all inline styes and additional usage of CSS classes so everybody can have its own style. Inline styles dictate the view too strictly with no option for any customization.

@gaearon
Copy link
Contributor

gaearon commented Oct 16, 2015

Accidental don't happen because somebody doesn't know what they're doing. :-) They happen because we are people, not robots.

@kromit
Copy link
Author

kromit commented Oct 16, 2015

Right. I mean it is not that severe since the target user group does know how to handle it :)

@gaearon
Copy link
Contributor

gaearon commented Oct 16, 2015

Even with the current version I often misclick because the click area isn't large enough. Knowing what to do isn't enough. :-)

@kromit
Copy link
Author

kromit commented Oct 16, 2015

So configurable styles would allow you to make it bigger more easily...? ;D

@gaearon
Copy link
Contributor

gaearon commented Oct 17, 2015

I'm closing this issue because it is not directly actionable in this repo anymore, as the log monitor has been separated. The issue now lives as gaearon/redux-devtools-log-monitor#1, and a PR to fix it is welcome.

@gaearon gaearon closed this as completed Oct 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants