Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project Maintenance #502

Closed
madcapnmckay opened this issue Mar 2, 2020 · 21 comments
Closed

Project Maintenance #502

madcapnmckay opened this issue Mar 2, 2020 · 21 comments

Comments

@madcapnmckay
Copy link

It seems like the redux devtools project has fallen into a state of disrepair. I've been occasionally dipping in and out over the last year, waiting to update to the latest cli package and leverage some of the new features that were added.

There are a number of issues that I see with the project at present.

  • Published NPM versions are out of sync with the current code and documentation. Which is especially confusing for new developers trying to get the tools to work as described.
  • Issues are piling up and not being responded to.
  • A fair number of PRs that are in need of merging, from as far back as Jan 2019.

I'm sympathetic to the burden of maintaining a OSS project. I was wondering if the current maintainers would be open to allowing others on board. I myself would be open to trying to clean up some of the outstanding items as my team directly benefits from the tooling.

I'm sure there are others who would be open to sharing some of the burden.

@gaearon @zalmoxisus @timdorr @bvaughn

Thanks

@timdorr
Copy link
Member

timdorr commented Mar 2, 2020

Yeah, definitely. I'm generally pretty permissive about this kind of thing.

Are there any PRs you want to champion towards merging? Any other folks you'd like to recruit?

We can start with write access to the repo and go from there.

@timdorr
Copy link
Member

timdorr commented Mar 2, 2020

BTW, I pinged Dan to give me npm access. If Mihail isn't available (he's probably pretty busy) to give access to the Chrome Extension publishing group, we may have to make a new one in the Chrome Web Store.

@madcapnmckay
Copy link
Author

The number 1 issue I'd like to address is the npm version publish disconnect. There are also some PRs/Issues that are related to updating dependencies causing people to have to fork themselves.

I'm hesitant to dive into that before learning some context. I will start to go through the issue backlog and see if I can get the lay of the land.

@zalmoxisus
Copy link
Collaborator

@timdorr I added you to npm. Let me know your email address you want to use for Chrome Extension publishing group as well. It would require some time to check everything before publishing as Chrome autoupdates the extension and in case of some issues it could break many sites (as many leave it in production) and there's also risk of stealing users data in case of some packages being compromised.

There was a lot of work in progress in this repository in order to move all extension's part here, it was intended to change almost everything starting from the ui and ending with monitors and the way of sending data. I got some severe family issues and won't be able to work on it anytime soon. If someone wants to take the leadership here, that would be more than welcome.

@timdorr
Copy link
Member

timdorr commented Mar 2, 2020

Perfect, thanks! I'm <my username>@gmail.com for all things Google.

I can take a look through the deployment setup we've got. I've actually been a long-time developer on the CWS, so I've got some tooling I can pull in to help automate that stuff.

I'm more than happy to take that off your plate so you can focus on the important things in life. Hope that all gets better soon!

@zalmoxisus
Copy link
Collaborator

I added you @timdorr. Also I need you to register at https://addons.mozilla.org/en-US/developers/ or if using another address already there let me know for publishing Firefox extension. Thanks for helping!

@timdorr
Copy link
Member

timdorr commented Mar 3, 2020

I use mozilla@timdorr.com over there.

@zalmoxisus
Copy link
Collaborator

Granted owner rights. The other member who has the right to publish extensions is @jhen0409.

@timdorr
Copy link
Member

timdorr commented Mar 3, 2020

Cool, thank you!

@madcapnmckay
Copy link
Author

Great. Thanks @zalmoxisus and @timdorr. I'll try and carve out some time this week to dive in and see if I can be of use.

@Methuselah96
Copy link
Member

Methuselah96 commented Mar 5, 2020

@timdorr @madcapnmckay

I agree that the number one priority should be resolving the npm version publish disconnect.

The next step should probably be fixing the PR builds. I already created a PR for that in December, so that should probably be the first PR that gets merged, so that we can get the build working for other PRs.

On top of that, #482 is a simple PR that I would like to see merged (which fixes the issue with most number of up-votes). I can also help with upgrading other packages and other small changes if that would be helpful. I had started on a fork, but quickly realized that I would need to republish every package under a new name and change the import name as well, which was for obvious reasons not viable.

Is there anything else in particular that I can do to help share the burden of maintaining this project?

@timdorr
Copy link
Member

timdorr commented Mar 7, 2020

I think I just need to get a handle on the status of this monorepo versus Mihail's original one. There are diverging commits, so I don't want anything important to get lost.

It's on my list to get things taken care of and back on track.

@Methuselah96
Copy link
Member

Methuselah96 commented Mar 7, 2020

@timdorr Are you talking about the differences between some of the original repos and Mihail's fork of them to be used for the extension (e.g. https://github.com/alexkuz/redux-devtools-inspector vs. https://github.com/zalmoxisus/remotedev-inspector-monitor)? Do you want me to do the leg-work of trying to reconcile the differences between the two and make a PR with the changes?

@zalmoxisus
Copy link
Collaborator

The list of what has moved here is in #412. So basically all the necessary parts except the browser extension and its redux-devtools-extention npm package (optional helper used for ts and to replace the global variable). The plan was to rewrite a new version of browser extension from scratch here (with a new way of injecting the script and a new UI), and leave my repo as legacy one.

redux-devtools npm package was made by Dan and has nothing to do with browser extension. I can publish that on Monday to fix that issue with packages conflicts.

@zalmoxisus
Copy link
Collaborator

zalmoxisus commented Mar 7, 2020

@Methuselah96 those repos with differences at that time were merged in packages/redux-devtools-inspector and published to npm.

@Methuselah96
Copy link
Member

Methuselah96 commented Mar 7, 2020

@zalmoxisus I see that now, thanks!
@timdorr I guess I might have misunderstood what you were saying. Which of Mihail's repos are you referring to?

@Methuselah96
Copy link
Member

Methuselah96 commented Mar 8, 2020

@zalmoxisus Although, I don't think the latest version of redux-devtools-inspector has been published to npm. The latest version on npm is 0.11.3 which was published on 3/5/2017 which doesn't include important fixes like alexkuz/redux-devtools-inspector@5202f01 (see #481). I've been unable to use the version of redux-devtools-inspector that is on npm and have to rely on on workarounds (like this: alexkuz/redux-devtools-inspector#71 (comment)). Maybe it didn't publish successfully because there's already a published version of 0.11.0 (which is the current version number in the monorepo: https://github.com/reduxjs/redux-devtools/blob/master/packages/redux-devtools-inspector/package.json#L3)?

@timdorr
Copy link
Member

timdorr commented Mar 10, 2020

@Methuselah96 I thought the redux-devtools-extension was this repo. I guess I have those confused. Still learning!

@Methuselah96
Copy link
Member

@timdorr Any updates on this? No worries if not, I just wanted to make sure it hasn't been forgotten since it's been a couple of weeks. I'm looking forward to this project getting back to a maintained state. As always, let me know if there's anything I can do to help move this along.

@timdorr
Copy link
Member

timdorr commented Mar 24, 2020

Not at the moment. We just closed our first funding round at my startup, so things are kind of hectic, along with all the COVID-19 craziness. I will try to get to it soon.

This was referenced Apr 30, 2020
@timdorr
Copy link
Member

timdorr commented May 4, 2020

Just added @Methuselah96 to the team and cleaned up a bunch of PRs. Hopefully, that means we're getting things on track. I'm going to close this out, but feel free to open another issue like this if we don't stick to our word :)

@timdorr timdorr closed this as completed May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants