Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slows down with the amount of actions displayed #81

Closed
whodidthis opened this issue Aug 20, 2015 · 7 comments
Closed

Slows down with the amount of actions displayed #81

whodidthis opened this issue Aug 20, 2015 · 7 comments

Comments

@whodidthis
Copy link

Do a lot of items on examples/todomvc or write some forms with a form helper like redux-form, and redux-devtools starts to slow down. Looking at Chrome profiles a lot of time (90%?) seems to be used on React proptype validation. I wonder if removing those would make sense?

2015-08-20-232056_1920x1080_scrot

@gaearon
Copy link
Contributor

gaearon commented Aug 20, 2015

There is a giant room for optimization there but I'm not ready to even attempt it until we write some tests. Until it's optimized, yes, it will be slow.

@gaearon
Copy link
Contributor

gaearon commented Aug 20, 2015

As a temporary measure, you can "Commit" at any time (in the top bar), and the log will start from there.

@gaearon
Copy link
Contributor

gaearon commented Sep 27, 2015

There's a PR attempted to fix it: #133
Can you please test whether it improves the situation?

@gaearon
Copy link
Contributor

gaearon commented Sep 27, 2015

Fixed by #133, out in redux-devtools@2.1.5.
Wouldn't have happened without tests contributed by @ellbee.

@gaearon gaearon closed this as completed Sep 27, 2015
@tals
Copy link

tals commented Oct 15, 2015

Still slow for me (running redux-devtools@2.1.5).

Tried out https://github.com/erikras/react-redux-universal-hot-example, typed some stuff into the redux-form input, and performance nosedives.

@gaearon
Copy link
Contributor

gaearon commented Oct 16, 2015

Nice, finally somebody provides a way to reproduce :-).
Can you tell if #146 improves things?

@gaearon
Copy link
Contributor

gaearon commented Oct 17, 2015

Please try Redux DevTools 3.0 Beta 2 and leave feedback.
It includes React 0.14 support: https://github.com/gaearon/redux-devtools/releases/tag/v3.0.0-beta-2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants