Add check to dispatcher for undefined action and undefined action type #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dmitry-zaets thank you for the contribution 👍 It looks good to me. If it doesn't work with people they will open issues 💃 |
|
@arnaudbenard Thanks for a cool library! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our team, we've been facing issues when we've misspelled action export or action type, and as a result - tests was passing but the application was failing.
Took them from redux's dispatcher method https://github.com/reactjs/redux/blob/master/src/createStore.js#L157-L162
What do you think about adding such checks into dispatcher?
I'm ok if, you don't want to overcomplicate your library with that kind of stuff.