Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ts): add Dispatch overload to redux module #278

Merged
merged 1 commit into from
Feb 10, 2020
Merged

feat(ts): add Dispatch overload to redux module #278

merged 1 commit into from
Feb 10, 2020

Conversation

iamandrewluca
Copy link
Contributor

It seems #259 author is not active anymore

Closes #259

It seems #259 author is not active anymore

Closes #259
@timdorr timdorr marked this pull request as ready for review February 10, 2020 16:15
@timdorr
Copy link
Member

timdorr commented Feb 10, 2020

Yep, this works. Thanks!

@timdorr timdorr merged commit d28ab03 into reduxjs:master Feb 10, 2020
@iamandrewluca iamandrewluca changed the title wip: feat(ts): add Dispatch overload to redux module feat(ts): add Dispatch overload to redux module Feb 10, 2020
@iamandrewluca iamandrewluca deleted the ashleigh branch February 10, 2020 21:08
@mtsmfm
Copy link

mtsmfm commented Mar 6, 2020

Awesome!

@timdorr Do you have any plan to cut a new release?

I guess this patch helps to improve not only this library but also @types/react-redux

https://github.com/DefinitelyTyped/DefinitelyTyped/blob/e534774027767502c673b7f9b2859c1b3cbe9087/types/react-redux/index.d.ts#L522-L525
DefinitelyTyped/DefinitelyTyped#34913

I'd like to help you if there is a release blocker

@marcelorubim
Copy link

Any plan for a new release?

Currently, using the useDispatch the type ThunkAction is accepted, but using the store.dispatch it's not accepted.

@timdorr timdorr mentioned this pull request Sep 11, 2020
arseneyr added a commit to arseneyr/redux-thunk that referenced this pull request Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants