Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[package.json] add ^5.0.0-beta.0" to peerDependencies #349

Merged
merged 3 commits into from Aug 19, 2023

Conversation

ryota-murakami
Copy link
Contributor

I saw this error while yarn install in this project.

error "@reduxjs/toolkit#redux-thunk#redux@^4" doesn't satisfy found match of "redux@5.0.0-beta.0"

So I added || ^5.0.0-beta.0" to peerDependencies as same as react-redux

@markerikson
Copy link
Contributor

Thanks! We do need to update the lockfile by re-running yarn first and saving yarn.lock - could you do that and update the PR?

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 29, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 698241d:

Sandbox Source
Vanilla Configuration
Vanilla Typescript Configuration

@ryota-murakami
Copy link
Contributor Author

@markerikson Run yarn and pushed yarn.lock changes!

@ryota-murakami
Copy link
Contributor Author

@markerikson It seems that the cause of failure of each version of TypeScript CI is all due to the exists of unnecessary @ts-expect-error.
If you don't want to merge PRs with CI failing, Can I fix it and commit it here?

@markerikson
Copy link
Contributor

@ryota-murakami please do, thanks!

@ryota-murakami
Copy link
Contributor Author

@markerikson I', sorry for late response.
Fix unnneseary ts-expect-error cmment for faild CI.

@exuanbo
Copy link

exuanbo commented Aug 3, 2023

When can this PR be merged?

@ryota-murakami
Copy link
Contributor Author

@exuanbo This is tweak, don't affected actual behavior.
@markerikson is extremely busy that said on Twitter, so I think we shouldn’t give urgently pressures maintainers.

@exuanbo
Copy link

exuanbo commented Aug 9, 2023

This is a tweak and does not affect the actual behavior.

I'm currently using npm version 9. If I don't include "override": { "redux": "5.0.0-beta.0" } in my package.json, or if I don't use the --legacy-peer-deps argument, the installation will fail due to a version conflict.

This issue could potentially discourage developers from experimenting with this beta version.

@ryota-murakami
Copy link
Contributor Author

@exuanbo I'm using pnpm so I didn't notice that. I'm sorry.
I guess might be soon merge & release when @markerikson refer this conversation!

@markerikson markerikson merged commit ca8df60 into reduxjs:master Aug 19, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants