fix: add babel-plugin-add-module-exports for default export #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[upgrading to Babel 6](reduxjs@6577fb6) silently broke everyone using `redux-thunk` with CommonJS `require` and `module.exports` due to [Kill CommonJS default export behaviour - babel/babel#2212](https://phabricator.babeljs.io/T2212). this fixes that (unintended?) breaking change. see also: - LogRocket/redux-logger@0b34fb9 - https://github.com/59naga/babel-plugin-add-module-exports
|
for reference to anyone who is affected, here's the error: const { applyMiddleware } = require('redux')
const thunk = require('redux-thunk')
applyMiddleware(thunk)until this PR is merged, the quick hack is to do: const thunk = require('redux-thunk').default |
gaearon
added a commit
that referenced
this pull request
Dec 14, 2015
fix: add babel-plugin-add-module-exports for default export
|
D'oh. Thanks! |
ahdinosaur
added a commit
to ahdinosaur/redux-devtools-dock-monitor
that referenced
this pull request
Dec 14, 2015
[upgrading to Babel 6](gaearon@766cdad) silently broke everyone using `redux-devtools-dock-monitor` with CommonJS `require` and `module.exports` due to [Kill CommonJS default export behaviour - babel/babel#2212](https://phabricator.babeljs.io/T2212). this fixes that unintended breaking change. repeat of reduxjs/redux-thunk#41
ahdinosaur
added a commit
to ahdinosaur/redux-devtools-log-monitor
that referenced
this pull request
Dec 14, 2015
[upgrading to Babel 6](gaearon#10) silently broke everyone using `redux-devtools-log-monitor` with CommonJS `require` and `module.exports` due to [Kill CommonJS default export behaviour - babel/babel#2212](https://phabricator.babeljs.io/T2212). this fixes that unintended breaking change. repeat of reduxjs/redux-thunk#41
|
@gaearon woo awesome, thanks for merging and re-publishing. 😃 here's two more: gaearon/redux-devtools-dock-monitor#18 and gaearon/redux-devtools-log-monitor#19. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
upgrading to Babel 6 silently broke everyone using
redux-thunkwith CommonJSrequireandmodule.exportsdue to Kill CommonJS default export behaviour - babel/babel#2212. this fixes that (unintended?) breaking change.see also: