Skip to content

Commit

Permalink
Update Reselect usages and types
Browse files Browse the repository at this point in the history
  • Loading branch information
markerikson committed Dec 1, 2023
1 parent 280b88b commit dc0b467
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 11 deletions.
4 changes: 2 additions & 2 deletions packages/toolkit/src/createDraftSafeSelector.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { current, isDraft } from 'immer'
import { createSelectorCreator, defaultMemoize } from 'reselect'
import { createSelectorCreator, weakMapMemoize } from 'reselect'

export const createDraftSafeSelectorCreator: typeof createSelectorCreator = (
...args: unknown[]
Expand All @@ -22,4 +22,4 @@ export const createDraftSafeSelectorCreator: typeof createSelectorCreator = (
* @public
*/
export const createDraftSafeSelector =
createDraftSafeSelectorCreator(defaultMemoize)
createDraftSafeSelectorCreator(weakMapMemoize)
7 changes: 1 addition & 6 deletions packages/toolkit/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,7 @@ export {
defaultMemoize,
weakMapMemoize,
} from 'reselect'
export type {
Selector,
OutputParametricSelector,
OutputSelector,
ParametricSelector,
} from 'reselect'
export type { Selector, OutputSelector } from 'reselect'
export {
createDraftSafeSelector,
createDraftSafeSelectorCreator,
Expand Down
6 changes: 3 additions & 3 deletions packages/toolkit/src/query/createApi.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import { DefinitionType, isQueryDefinition } from './endpointDefinitions'
import { nanoid } from './core/rtkImports'
import type { UnknownAction } from '@reduxjs/toolkit'
import type { NoInfer } from './tsHelpers'
import { defaultMemoize } from 'reselect'
import { weakMapMemoize } from 'reselect'

export interface CreateApiOptions<
BaseQuery extends BaseQueryFn,
Expand Down Expand Up @@ -253,7 +253,7 @@ export function buildCreateApi<Modules extends [Module<any>, ...Module<any>[]]>(
...modules: Modules
): CreateApi<Modules[number]['name']> {
return function baseCreateApi(options) {
const extractRehydrationInfo = defaultMemoize((action: UnknownAction) =>
const extractRehydrationInfo = weakMapMemoize((action: UnknownAction) =>
options.extractRehydrationInfo?.(action, {
reducerPath: (options.reducerPath ?? 'api') as any,
})
Expand Down Expand Up @@ -304,7 +304,7 @@ export function buildCreateApi<Modules extends [Module<any>, ...Module<any>[]]>(
},
apiUid: nanoid(),
extractRehydrationInfo,
hasRehydrationInfo: defaultMemoize(
hasRehydrationInfo: weakMapMemoize(
(action) => extractRehydrationInfo(action) != null
),
}
Expand Down

0 comments on commit dc0b467

Please sign in to comment.