Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.0.0-rc.2 inundates console with warnings from runIdentityFunctionCheck #3930

Closed
christopherschroer opened this issue Dec 1, 2023 · 2 comments
Milestone

Comments

@christopherschroer
Copy link

v2.0.0-rc.2 inundates consoles with warnings from runIdentityFunctionCheck. This is evident in the console output for the tests that were ran as part of #3928 (https://github.com/reduxjs/redux-toolkit/actions/runs/7055909073/job/19207110065)

@EskiMojo14
Copy link
Collaborator

Thanks for the report! It looks like useMutation defaults selectFromResult to an identity function, instead of doing what useQuery does and only calling createSelector when a selectFromResult selector is passed.

The PR linked above should fix this.

@markerikson
Copy link
Collaborator

@christopherschroer yeah, try using the CSB build from that PR:

# yarn 1
yarn add https://pkg.csb.dev/reduxjs/redux-toolkit/commit/f3736dc5/@reduxjs/toolkit
# yarn 2, 3
yarn add @reduxjs/toolkit@https://pkg.csb.dev/reduxjs/redux-toolkit/commit/f3736dc5/@reduxjs/toolkit/_pkg.tgz 
# npm
npm i https://pkg.csb.dev/reduxjs/redux-toolkit/commit/f3736dc5/@reduxjs/toolkit

We'll get out another RTK RC later today, along with a tweak to Reselect to include a stack trace.

@markerikson markerikson added this to the 2.0 milestone Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants